Repository navigation
Core: allow per-ad-unit video cache opt-out - #15716
Conversation
|
looks like some conflicts. and you might have to alter the logic a bit because |
Barecheck - Code coverage reportTotal: 91.59%Your code coverage diff: 0.00% ▴ Uncovered files and lines
|
|
Merged current master and applied |
|
This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:
The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Closes #15710.
Add the typed
mediaTypes.video.cacheoption. Setting it tofalseskips remote and local caching performed by Prebid.js for that ad unit's video bids. Omission andtruepreserve existing rules. Cached and opted-out units can share an auction without changing global configuration, including when auctions overlap. Audio caching on mixed audio/video units is unchanged.This option does not disable caching by Prebid Server or bidders. Supplied VAST URLs and cache keys are preserved, even when
cache.ignoreBidderCacheKeyis enabled. For outstream video,cache: falsetakes precedence over renderer-driven caching: an XML-only bid is rejected if its active renderer requires a VAST URL. A supplied VAST URL remains usable.Documentation: prebid/prebid.github.io#6784.
Validation:
npx gulp test-only --browsers ChromeHeadless: 26,126 passed, 7 skipped, zero failures.gulp lint --nolintfix, TypeScript checks andgit diff --checkpass.d12d5e8f5in Chrome 155. Both cached and directly consumed VAST played, tracked completion and resumed content. Mixed auctions made one cache POST; the default control made two. Later edits only clarify JSDoc and add a contract regression. This used controlled bids and a local cache endpoint; production publisher deployment remains untested.Maintainer label request:
feature,minor,core. My fork account cannot apply these labels.