Repository navigation
Core: cache outstream VAST when renderer needs a URL - #15715
Merged
patmmccann merged 1 commit intoOct 5, 2026
Merged
Conversation
This was referenced Oct 4, 2026
patmmccann
requested review from
dgirardi and
mkomorski
and removed request for
mkomorski
October 4, 2026 10:41
dgirardi
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add
requiresVastUrlto top window and Safe Renderer configuration. For XML-only outstream video bids, Prebid caches VAST when the selected renderer needs a URL. Bids that already containvastUrlbypass this new cache path. ExistingmediaTypes.video.useCacheKeybehavior remains available.The selected top window renderer carries the option through
Renderer.install(src/Renderer.ts:126,src/auction.ts:832). The cache decision uses Safe Renderer precedence and completes the auction callback when a URL-required bid cannot be served (src/videoCache.ts:276). Tests cover renderer selection, remote and local caching, existing URLs, inline XML renderers, and cache-disabled rejection.Closes #11353.
Documentation PR: prebid/prebid.github.io#6783.
Related PR #15716 adds an explicit per-ad-unit cache opt-out. The two PRs edit the same cache decision and test block. After the first merges, the second needs a rebase. In the combined behavior,
cache: falsetakes precedence; an XML-only bid whose renderer requires a URL is rejected rather than cached or passed to that renderer. I verified that interaction in a temporary combined branch with the focused video cache tests.Checks
npx gulp test-only: 25,640 tests passed across eight chunks.npx gulp lint --nolintfix --files src/Renderer.ts,src/adUnits.ts,src/auction.ts,src/videoCache.ts,test/spec/auctionmanager_spec.js,test/spec/videoCache_spec.js: passed.git diff --check: passed.Maintainers: please apply
featureandminorlabels. GitHub denied this account permission to add labels.