deps: bump pingcap base image to v1.12.5 by time-and-fate · Pull Request #7107 · pingcap/tidb-operator

time-and-fate · 2026-10-23T15:14:46Z

What problem does this PR solve?

Bump the ghcr.io/pingcap-qe/bases/pingcap-base base image from v1.12.3 to v1.12.5 (digest-pinned) across the five Dockerfiles that reference it. This is a routine base-image refresh, picking up the latest base image patch release as a follow-up to #7041.

What is changed and how does it work?

No operator code changes. Only the FROM line of five Dockerfiles is updated:

cmd/http-service/Dockerfile
images/br-federation-manager/Dockerfile
images/br-federation-manager/Dockerfile.e2e
images/tidb-operator/Dockerfile
images/tidb-operator/Dockerfile.e2e

The tag moves v1.12.3 -> v1.12.5 and the digest is re-pinned to the v1.12.5 manifest-list digest (sha256:715150b855957b5a007b006240b2735b3e645c5a471d2391ad9ffa4aafdb93fd), obtained from the ghcr.io registry (anonymous token + Docker-Content-Digest header on the manifest-list media type, same method as #7021). The same digest is pinned by the pending v2 bump #7105.

The release-1.x counterpart is #7106 — independent edit, since the two branches' Dockerfiles are independent and a cherry-pick of a single-line FROM change adds no value over a direct edit.

Code changes

Has Go code change
Has CI related scripts change

Tests

Unit test
E2E test
Manual test
No code

Local verification:

git diff shows exactly the five FROM lines changed, nothing else.
grep -rn 'v1\.12\.3' across the repo returns no remaining references.
The digest matches the v1.12.5 manifest-list digest returned by the ghcr registry, and the same query against v1.12.3 returns the digest previously pinned in these files, confirming the digest type is consistent.

Side effects

Breaking backward compatibility
Other side effects: base image patch release; no functional change expected. CI image builds will pull the new base layer.

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Counterpart PR on release-1.x: #7106.

Release Notes

Bump the pingcap base image to v1.12.5.

Summary by CodeRabbit

Chores
- Updated the base image version used to build the HTTP service, federation manager, and TiDB Operator containers, including their end-to-end test images. No user-facing functionality changes are included.

ti-chi-bot · 2026-10-23T15:14:51Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign handlerww for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-10-23T15:15:02Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 57ac4c01-524f-4416-8337-5840b4b26b4f

📥 Commits

Reviewing files that changed from the base of the PR and between bbc9adb and 2e65328.

📒 Files selected for processing: 5

cmd/http-service/Dockerfile
images/br-federation-manager/Dockerfile
images/br-federation-manager/Dockerfile.e2e
images/tidb-operator/Dockerfile
images/tidb-operator/Dockerfile.e2e

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📝 Walkthrough

Five Dockerfiles now use pingcap-base:v1.12.5 instead of v1.12.3. Each file also updates the pinned image digest.

Changes: Base Image Updates

Layer / File(s)	Summary
Update Dockerfile base images `cmd/http-service/Dockerfile`, `images/br-federation-manager/Dockerfile`, `images/br-federation-manager/Dockerfile.e2e`, `images/tidb-operator/Dockerfile`, `images/tidb-operator/Dockerfile.e2e`	All five Dockerfiles now use `pingcap-base:v1.12.5` with its corresponding digest.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Suggested reviewers: wuhuizuo

Merge Risk: ⚪ Minimal · up to 2e653

No actionable current-head risk is identified; the image bump is mergeable subject to normal CI checks.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title "deps: bump pingcap base image to v1.12.5" matches the main change. The PR updates the digest-pinned pingcap-base image from v1.12.3 to v1.12.5 across five Dockerfiles, and the raw summary c…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "deps: bump pingcap base image to v1.12.5" matches the main change. The PR updates the digest-pinned pingcap-base image from v1.12.3 to v1.12.5 across five Dockerfiles, and the raw summary confirms only FROM lines changed with no code changes. The title is concise, specific, and does not describe anything absent from the changeset.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)

✨ Finishing Touches: 💡 1

🧪 Generate unit tests (beta)

Create a new PR

🛠️ Fix failing CI checks: 💡

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{A rabbit checks each pinned tag,
Then sees the newer base image.
Five Dockerfiles hop in line,
Their digests updated too.
The rabbit rests beside the build.}

_{Comment @coderabbitai help to get the list of available commands.}

time-and-fate · 2026-10-23T16:11:41Z

/retest

time-and-fate · 2026-10-23T18:11:57Z

/retest

time-and-fate · 2026-10-23T19:19:05Z

/retest

time-and-fate · 2026-10-24T09:50:24Z

/retest

time-and-fate · 2026-10-24T13:32:56Z

/retest

deps: bump pingcap base image to v1.12.5

2e65328

ti-chi-bot Bot requested a review from shonge October 23, 2026 15:14

ti-chi-bot Bot added the size/S label Oct 23, 2026

time-and-fate mentioned this pull request Oct 23, 2026

deps: bump pingcap base image to v1.12.5 #7106

Open

2 of 10 tasks

coderabbitai Bot approved these changes Oct 23, 2026

View reviewed changes

takaidohigasi mentioned this pull request Oct 27, 2026

e2e: pull the BR minio image from the pingcap-public mirror #7114

Open

3 of 10 tasks

Navigation Menu

Repository navigation

deps: bump pingcap base image to v1.12.5 - #7107

deps: bump pingcap base image to v1.12.5#7107
time-and-fate wants to merge 1 commit into
pingcap:release-1.6from
time-and-fate:261023-base-image-1.12.5-1.6

time-and-fate commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

ti-chi-bot Bot commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

time-and-fate commented Oct 23, 2026

Uh oh!

time-and-fate commented Oct 23, 2026

Uh oh!

time-and-fate commented Oct 23, 2026

Uh oh!

time-and-fate commented Oct 24, 2026

Uh oh!

time-and-fate commented Oct 24, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

time-and-fate commented Oct 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how does it work?

Code changes

Tests

Side effects

Related changes

Release Notes

Summary by CodeRabbit

Uh oh!

ti-chi-bot Bot commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

time-and-fate commented Oct 23, 2026

Uh oh!

time-and-fate commented Oct 23, 2026

Uh oh!

time-and-fate commented Oct 23, 2026

Uh oh!

time-and-fate commented Oct 24, 2026

Uh oh!

time-and-fate commented Oct 24, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

time-and-fate commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading