Repository navigation
deps: bump pingcap base image to v1.12.5 - #7106
time-and-fate wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: updating the PingCAP base image to v1.12.5. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)
✨ Finishing Touches: 💡 1
-
🧪 Generate unit tests (beta)
-
- Create a new PR
🛠️ Fix failing CI checks: 💡
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the tags at dawn
Five image pins have moved along
New digests mark the updated trail
The Dockerfiles now share the same tale
I nibble carrots, neat and small.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
/retest |
5 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
What problem does this PR solve?
Bump the
ghcr.io/pingcap-qe/bases/pingcap-basebase image from v1.12.3 to v1.12.5 (digest-pinned) across the five Dockerfiles that reference it. This is a routine base-image refresh, picking up the latest base image patch release as a follow-up to #7040.What is changed and how does it work?
No operator code changes. Only the
FROMline of five Dockerfiles is updated:cmd/http-service/Dockerfileimages/br-federation-manager/Dockerfileimages/br-federation-manager/Dockerfile.e2eimages/tidb-operator/Dockerfileimages/tidb-operator/Dockerfile.e2eThe tag moves
v1.12.3->v1.12.5and the digest is re-pinned to the v1.12.5 manifest-list digest (sha256:715150b855957b5a007b006240b2735b3e645c5a471d2391ad9ffa4aafdb93fd), obtained from the ghcr.io registry (anonymous token +Docker-Content-Digestheader on the manifest-list media type, same method as #7020). The same digest is pinned by the pending v2 bump #7105.A release-1.6 counterpart is opened separately (#7107) — independent edit, since the two branches' Dockerfiles are independent and a cherry-pick of a single-line FROM change adds no value over a direct edit.
Code changes
Tests
Local verification:
git diffshows exactly the fiveFROMlines changed, nothing else.grep -rn 'v1\.12\.3'across the repo returns no remaining references.Side effects
Related changes
Counterpart PR on release-1.6: #7107.
Release Notes
Summary by CodeRabbit