Repository navigation
ppg 17: -devel requires llvm-devel and clang-devel - #179
Merged
Merged
Conversation
The PG 17 server is built --with-llvm, so its Makefile.global sets
CLANG=/usr/bin/clang and PGXS compiles every extension's .bc bitcode
with it. percona-postgresql17-devel did not require clang, so extension
builds on hosts without it failed:
make: /usr/bin/clang: No such file or directory
(release QA: credcheck and PostGIS on rocky9, pg_stat_monitor on EL10).
Add the same `%if %llvm` Requires on llvm-devel/clang-devel >= 19.0 that
the PG 14-16 specs carry (matching PG 17's own llvmjit `Requires: llvm
>= 19`) to the staging:17 and staging:17:extras server specs.
Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release PR #148's QA failed three PG 17 component lanes the same way:
The PG 17 server is built
--with-llvm, so itsMakefile.globalsetsCLANG=/usr/bin/clangand PGXS compiles every extension's.bcbitcode with it.percona-postgresql17-develdid not require clang, so extension builds on a host without it fail. The PG 18 lanes on the same hosts passed because PG 18's-develalready requires clang.What
Both PG 17 server specs (
root/ppg/staging/17androot/ppg/staging/17/extras) get, in%package devel:Same block as the PG 14, 15 and 16 specs; 19 matches PG 17's own
llvmjit(Requires: llvm >= 19).Audit of the other majors (
rpmspec -Pper EL): 14, 15, 16, 16:extras and 16:tde build--with-llvmand requirellvm-devel >= 19.0 clang-devel >= 19.0on EL8/9/10; 18 and 19 require clang too. PG 17 was the only gap.Verification
rpmspec -Pexpands the new Requires on EL8, EL9 and EL10 for both specs.project verify --offlinepasses forppg:staging:17andppg:staging:17:extras.Rebuilds the PG 17 server and everything depending on it (extensions, images, tarballs).