Repository navigation
fix: support Frappe v15 again - #1007
Merged
Merged
Conversation
version-15 ships the @framework/ui telemetry and TrialBanner the frontend imports from 15.121.3, so lower the floor to that. Bench, Pilot and Frappe Cloud parse this range with three different libraries and no syntax they share can hold a floor per major. v16 benches between 16.0 and 16.36.0 now pass the check and fail the asset build instead; Pilot reverts such an update on its own. Also fix the two v15 runtime gaps: frappe.in_test does not exist there (frappe.flags.in_test works on both), and the editor demo's joined script query sorted by an ambiguous idx. Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1007 +/- ##
===========================================
+ Coverage 81.01% 81.03% +0.01%
===========================================
Files 66 66
Lines 7137 7139 +2
===========================================
+ Hits 5782 5785 +3
+ Misses 1355 1354 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowers the Frappe floor to
>=15.121.3,<18.0.0so v15 benches can install and update Builder again. 15.121.3 is the first version-15 release whose@framework/uihas thetelemetryandTrialBannerthe frontend imports.This undoes part of 9b3d6fb (#952). One range can't hold a floor per major version: bench and the FC agent read it with
semantic_version.SimpleSpec, which rejects||next to commas. Pilot uses PEP 440, which has no||. FC marketplace usesNpmSpec, which has no!=. So v16 benches from 16.0 to 16.36.0 pass the check again and fail at the asset build. Pilot reverts such an update on its own, and plain bench only ever printed a warning.Two v15 runtime fixes:
frappe.in_testdoesn't exist on v15. The standard folder and template page guards hit it outside developer mode.frappe.flags.in_testworks on both.idx, which v15 rejects as ambiguous (MySQL 1052).Tested on a Frappe v15.121.3 bench (Python 3.11):
bench get-appand the asset build pass, the dashboard and editor load, a page publishes and serves, and the folder guard and editor demo payload work. The console shows a 417 frompulse.client.boot_config: the version-15 telemetry backport has no such endpoint, so telemetry stays off there.