Repository navigation
fix: support Frappe v15 again - #1008
Merged
surajshetty3416 merged 1 commit intoOct 28, 2026
Merged
Conversation
version-15 ships the @framework/ui telemetry and TrialBanner the frontend imports from 15.121.3, so lower the floor to that. Bench, Pilot and Frappe Cloud parse this range with three different libraries and no syntax they share can hold a floor per major. v16 benches between 16.0 and 16.36.0 now pass the check and fail the asset build instead; Pilot reverts such an update on its own. Also fix the two v15 runtime gaps: frappe.in_test does not exist there (frappe.flags.in_test works on both), and the editor demo's joined script query sorted by an ambiguous idx. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
|
🎉 This PR is included in version 1.36.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1008 +/- ##
==========================================
+ Coverage 75.52% 75.54% +0.01%
==========================================
Files 112 112
Lines 12362 12364 +2
==========================================
+ Hits 9337 9340 +3
+ Misses 3025 3024 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1007 to master. Merging this cuts v1.36.3, the first release since v1.35.2 that installs on Frappe v15 (15.121.3 and later).