Skip to content

OKAPI-1268: Add producesEvents and consumesEvents to ModuleDescriptor - #1486

Merged
julianladisch merged 4 commits into
masterfrom
OKAPI-1268
Nov 3, 2026
Merged

julianladisch merged 4 commits into
masterfrom
OKAPI-1268

Conversation

@julianladisch

Copy link
Copy Markdown
Contributor

https://folio-org.atlassian.net/browse/OKAPI-1268

  • Add producesEvents and consumesEvents to ModuleDescriptor
  • With this change, modules can declare the kafka events it produces and consumes.

@pkjacob

pkjacob commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Hi @julianladisch,

There are some sonar violation in the PR. I didn't notice it earlier as my original PR's build failed before running the sonar validations.

I have added this commit to fix two of the violations - 4d70097

If possible, can you please include the commit in this PR?

There are few more violations that I did not fix. The same violation exists in the other existing methods in ModuleDescriptor class. I followed the existing methods' pattern. Please let me know what you think. 

@julianladisch

Copy link
Copy Markdown
Contributor Author

You can ignore the warnings about "Return a copy" and "Store a copy"

@pkjacob

pkjacob commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Hi @julianladisch
Got more sonar violations after my latest commit.
Can you please include this commit also in the PR - 3473141

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@julianladisch
julianladisch merged commit 539b6d5 into master Nov 3, 2026
20 checks passed
@julianladisch
julianladisch deleted the OKAPI-1268 branch November 3, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants