Repository navigation
Conversation
pkjacob
marked this pull request as draft
October 30, 2026 18:32
pkjacob
force-pushed
the
pjacob/OKAPI-1268
branch
2 times, most recently
from
October 30, 2026 20:15
8109cf1 to
465ba15
Compare
pkjacob
marked this pull request as ready for review
October 30, 2026 20:19
pkjacob
force-pushed
the
pjacob/OKAPI-1268
branch
from
October 30, 2026 20:21
465ba15 to
5b0538f
Compare
Contributor
Author
|
This PR comes from a fork, so the CI workflows failed. (see this) git remote add pkjacob https://github.com/pkjacob/okapi Thanks! |
Comment on lines
+2984
to
+2993
| var md = new JsonObject(body); | ||
| var produces = md.getJsonArray("producesEvents"); | ||
| Assert.assertEquals(1, produces.size()); | ||
| Assert.assertEquals(produced, produces.getJsonObject(0).getString("event")); | ||
| var consumes = md.getJsonArray("consumesEvents"); | ||
| Assert.assertEquals(2, consumes.size()); | ||
| Assert.assertEquals(consumedOptional, consumes.getJsonObject(0).getString("event")); | ||
| Assert.assertEquals(Boolean.TRUE, consumes.getJsonObject(0).getBoolean("optional")); | ||
| Assert.assertEquals(consumedRequired, consumes.getJsonObject(1).getString("event")); | ||
| Assert.assertFalse(consumes.getJsonObject(1).containsKey("optional")); |
Contributor
There was a problem hiding this comment.
Using rest-assured's body method results in more concise tests. See lines 2893-2896 for an example.
Contributor
Author
There was a problem hiding this comment.
Nice. Thank You. Done.
julianladisch
approved these changes
Nov 3, 2026
julianladisch
left a comment
julianladisch
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks!
Contributor
|
Replaced with #1486 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
producesEventsandconsumesEventsto ModuleDescriptor