fix(coding-agent): clear delivered image-only queue entries - #8612
wutongyuonce wants to merge 1 commit into
Conversation
gaoanze888
left a comment
There was a problem hiding this comment.
Reviewed exact head b67b3db2a. Removing the non-empty-text guard is correct because the session-side queues store text only, including "" for image-only messages, while delivery is authoritatively signaled by the user message_start event.
I checked both queue modes and the cross-queue ordering. Agent core always drains steering before follow-up, matching this handler's steering-first removal; multiple image-only entries are removed one at a time in FIFO delivery order. Initial image-only prompts cannot remove anything because no session queue record exists, and aborted/undelivered entries are not cleared because no corresponding user message_start occurs.
Validation:
- queue suite plus local image-only follow-up / mixed steering+follow-up matrix: 17/17
- exact-head merge into current
origin/mainapplies cleanly git diff --check
The old PR base's full build is currently affected by live generated-model/catalog drift in untouched AI provider files; the focused coding-agent lifecycle tests pass. No blocker found.
This comment is AI-generated by /wr
|
Hi @mitsuhiko @badlogic — gentle bump. This PR is still open and mergeable. Happy to adjust anything once you have a chance to look. Thanks! |
Summary
Testing
npm run check./test.shFixes #8581