feat(coding-agent): allow extensions to append to the session system prompt - #9434
wutongyuonce wants to merge 2 commits into
Conversation
gaoanze888
left a comment
There was a problem hiding this comment.
Reviewed exact head c113a83 against current main. The new session_start result is append-only, collected sequentially in extension/handler order with existing error isolation, and every handler sees the same contribution-free base prompt. The snapshot is rebuilt for startup/new/resume/fork/reload, preserved across tool/resource rebuilds, and is not persisted. Prompt ordering is consistent in both default and custom branches, and the explicit _extensionsBound flag correctly handles empty bindings without opting unbound SDK sessions into lifecycle events. Public types/exports and documentation are aligned. The standalone system-prompt suite passes 16/16 locally; the remaining focused suites are blocked locally by generated package artifacts, while exact-head GitHub build-check-test is green. No blocker found.
|
Hi @mitsuhiko @badlogic — gentle bump. This PR is still open and mergeable. Happy to adjust anything once you have a chance to look. Thanks! |
|
Given the changes we landed now to sections in system prompts I would like to understand if the new system we have in place is not making this PR obsolete? |
|
@mitsuhiko you're right — this looks obsolete given the new system. The sections + mid-conversation system message design covers what I was trying to do here, and in a better way. The original problem was stable extension instructions having to live in a per-run Declaring the desired composition via |
Closes #9432
Summary
session_starthandlers to return append-onlysystemPromptAppendcontributionsbefore_agent_startinteractionTesting
npm run check./test.sh: the first run reached 2240 coding-agent passes; after dependency hydration, the remaining 3 focused failures require the missing localpackages/chord/distbuild artifactbuild-check-testgpt-5.6-lunasession; one type issue was fixed and the re-review found no remaining actionable findingsAI-assisted disclosure: this PR was prepared with AI assistance and reviewed against Issue #9432, the linked design, and the affected source paths.