feat(crunchy): stop after helm when dry_run is set - #70
Merged
Merged
Conversation
A hidden DEBUG_MODE dry-run still waited for the database and patched PR users, so validation crashed. dry_run validates with helm and exits before those steps. Closes #58
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The Helm command neither performs the promised server-side validation nor prevents rendered S3 secrets from reaching logs.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds a first-class Crunchy database dry-run mode that renders Helm resources without deployment or user changes.
Changes:
- Adds and documents the
dry_runinput. - Skips deployment side effects and readiness checks.
- Adds tests for dry-run behavior and failures.
| File | Description |
|---|---|
crunchy/scripts/deploy_db.sh |
Implements dry-run execution and early exit. |
crunchy/action.yml |
Wires the input and skips user changes. |
crunchy/README.md |
Documents dry-run behavior. |
.github/tests/crunchy/deploy_db.bats |
Tests dry-run paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
--dry-run=server submits the chart for API checks. --hide-secret omits Secret resources from the output. --debug is omitted because it prints user-supplied values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A hidden DEBUG_MODE dry-run still waited for the database and patched PR users, so validation crashed.
dry_runrunshelm upgrade --dry-run=server --hide-secret --installand exits 0 before the ready check. Server-side dry-run submits the chart for API checks. Secret resources are omitted from the output. It still renders when triggers would skip an already-deployed release, and it does not self-heal (that path deletes the PostgresCluster). The add-user and remove-user steps are skipped. A failed helm dry-run still fails the script.Closes #58