Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ and this project adheres to

- Update Project and Workflow yaml exports to match the v4 portability spec
[#4718](https://github.com/OpenFn/lightning/issues/4718)
- The workflow version hash no longer includes a trigger's `enabled` state
[#5241](https://github.com/OpenFn/lightning/pull/5241)

### Fixed

Expand Down
1 change: 0 additions & 1 deletion lib/lightning/workflow_versions.ex
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,6 @@ defmodule Lightning.WorkflowVersions do
:type,
:custom_path,
:cron_expression,
:enabled,
:webhook_reply,
:webhook_response_config,
:cron_cursor_job_id
Expand Down
4 changes: 2 additions & 2 deletions test/lightning/workflow_versions_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ defmodule Lightning.WorkflowVersionsTest do
# key costs nothing for the workflows that have no path. @openfn/project
# skips undefined for the same reason, which keeps the two sides equal.
assert WorkflowVersions.canonical_form(without_path) ==
"Testtruewebhookbefore_start@openfn/language-common@latestcodeJob A"
"Testwebhookbefore_start@openfn/language-common@latestcodeJob A"

Repo.update_all(
from(x in Lightning.Workflows.Trigger, where: x.id == ^trigger.id),
Expand Down Expand Up @@ -801,7 +801,7 @@ defmodule Lightning.WorkflowVersionsTest do
end

test "generates the same hash for this simple workflow" do
predetermined_hash = "05c455a228e6"
predetermined_hash = "ab95156e6e01"

simple_workflow = %{
name: "Simple Workflow",
Expand Down
Loading