Skip to content

Remove trigger.enabled from version hash - #5241

Merged
midigofrank merged 2 commits into
mainfrom
remove-enabled-from-version-hash
Oct 12, 2026
Merged

midigofrank merged 2 commits into
mainfrom
remove-enabled-from-version-hash

Conversation

@josephjclark

Copy link
Copy Markdown
Contributor

Description

This aligns with the CLI and latest portability spec, see the work in OpenFn/kit#1564

This reduces diff noise when merging project through git

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

@github-actions

Copy link
Copy Markdown

Security Review ✅

  • S0 (project scoping): N/A — the diff only removes :enabled from trigger_keys in canonical_form/1 (lib/lightning/workflow_versions.ex:275-282); no queries or endpoints change.
  • S1 (authorization): N/A — no new controller actions, LiveView events, or policy clauses are introduced.
  • S2 (audit trail): N/A — no new Repo.insert/update/delete on config resources; the change affects only how a workflow-version hash is computed.

@midigofrank
midigofrank merged commit 8c9c94a into main Oct 12, 2026
5 of 6 checks passed
@midigofrank
midigofrank deleted the remove-enabled-from-version-hash branch October 12, 2026 12:05
@github-project-automation github-project-automation Bot moved this from New Issues to Done in Core Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants