Repository navigation
Fix versioned SDK paths in generated build settings - #3355
Open
karim-alweheshy wants to merge 2 commits into
Open
karim-alweheshy wants to merge 2 commits into
karim-alweheshy wants to merge 2 commits into
Conversation
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
karim-alweheshy
marked this pull request as ready for review
October 7, 2026 18:38
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize versioned Bazel developer-directory aliases in generated build settings to
$(DEVELOPER_DIR). Add focused SDK-path regression tests.Validation
The diff adds focused SDK-path regression tests. Tests were not rerun for this description update.
Testing
Run
bazel test //tools/generators/target_build_settings:target_build_settings_testsand check versioned and unversioned SDK paths. This prerequisite does not itself enable Preview or claim Canvas rendering.