Repository navigation
Enable native Preview configurations and add the example - #3370
Draft
karim-alweheshy wants to merge 4 commits into
Draft
karim-alweheshy wants to merge 4 commits into
karim-alweheshy wants to merge 4 commits into
Conversation
added 4 commits
September 23, 2026 21:07
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connect the prepared native Preview metadata to target generation, expose dedicated native Preview configurations, and add a maintained resource-free example. Resource-bundle support is a separate follow-up.
Stack / landing boundary
The integration-only diff base combines #3369, #3355, #3356, and #3367 (the platform-ID prerequisite is already on
main). It is not a merge target. Land prerequisites first, then retarget/reconcile and revalidate.Validation
Recorded root/generated-documentation and formatting checks cover the prior base and candidate. Hosted checks reported success on the published head in the 2026-10-08 snapshot. Root tests exclude the example workspace; formatting does not prove project generation or Canvas rendering.
Testing
Run
bazel test //test/internal/pbxproj_partials:top_level_target_attributes_args //test/internal/processed_targets:mergeable_infos, then generate the maintained example, inspect native Preview settings, and require the expected view in Canvas. Check an ordinary build separately.