Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves error handling throughout the codebase by replacing the use of
catchwith more robusttry ... catchconstructs, ensuring more precise error matching and better stacktrace reporting. Additionally, it updates CI dependencies and enhances test coverage for error scenarios.Error handling improvements:
catchwithtry ... catchinz_convert.erlforto_utc/1andto_localtime/1, allowing for more granular error and exit handling when converting between local and UTC times. [1] [2]nows_protocol_split/2inz_html.erlto usetry ... catchfor binary-to-integer conversion, specifically catchingbadargerrors for invalid percent-encoded sequences.z_ubf.erlfordecode/2andencode/3to usetry ... catch, capturing both error reasons and stacktraces for improved debugging. [1] [2]Testing improvements:
z_convert_test.erlfor invalid timezone conversions and inz_ubf_test.erlfor decode/encode error cases, including assertions for error types and stacktraces. [1] [2]z_html:noscript/1.CI and dependency updates:
.github/workflows/test.ymlto test against newer OTP versions (27, 28, 29) and upgraded theactions/checkoutversion to v7 for improved CI reliability.