Repository navigation
Enable ffnvcodec for the build-nvenc and build-nvidia features - #140
Open
diogochaves wants to merge 1 commit into
Open
diogochaves wants to merge 1 commit into
diogochaves wants to merge 1 commit into
Conversation
The build passes --disable-autodetect, and ffnvcodec (the nv-codec-headers) is one of the libraries configure only looks for when it autodetects. So build-nvenc stops at "nvenc requested, but not all dependencies are satisfied: ffnvcodec" even with the headers installed, and build-nvidia's cuvid and nvenc need it too. Enable it explicitly with both features, and build the static CI job with build-nvenc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-nvencstops in FFmpeg's configure, even with the nv-codec-headers installed:The build script passes
--disable-autodetect, and ffnvcodec is one of the libraries configure only looks for when it autodetects (if ! disabled ffnvcodecaround the header check). nvenc, cuvid and cuda all depend on it, sobuild-nvidiahas the same gap.This enables ffnvcodec explicitly with both features, and adds
build-nvenc(andlibffmpeg-nvenc-dev) to the static CI job so the feature gets compiled.Tested on Arch with ffnvcodec-headers 13.1.15 and an RTX 5070 Ti, on 9.0.1:
build,static,build-nvencnow builds, andh264_nvencandhevc_nvencopen and encode through the static FFmpeg. I couldn't buildbuild-nvidia(no CUDA toolkit here); I only checked that configure with--enable-cuvid --enable-nvenc --enable-cuda-llvmneeds--enable-ffnvcodecto pass.