Skip to content

Add the POLL flow execution response type - #1195

Open
DilshanSenarath wants to merge 1 commit into
wso2:masterfrom
DilshanSenarath:qr-device-registration
Open

DilshanSenarath wants to merge 1 commit into
wso2:masterfrom
DilshanSenarath:qr-device-registration

Conversation

@DilshanSenarath

Copy link
Copy Markdown
Contributor

Adds POLL to the flow execution response type enum. The device registration step returns it while the browser waits for the user to register a device by scanning a QR code.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2e53e18d-807c-4dff-8271-75e46aae9d0e
Commits

Reviewing files that changed from the base of the PR and between eca2a0b and f83e4aa.

Files ignored due to path filters: 1
  • components/org.wso2.carbon.identity.api.server.flow.execution/org.wso2.carbon.identity.api.server.flow.execution.v1/src/gen/java/org/wso2/carbon/identity/api/server/flow/execution/v1/FlowExecutionResponse.java is excluded by !**/gen/**
Files selected for processing: 1
  • components/org.wso2.carbon.identity.api.server.flow.execution/org.wso2.carbon.identity.api.server.flow.execution.v1/src/main/resources/flow-execution.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Added POLL to the allowed values for FlowExecutionResponse.type. This supports responses while the browser waits for device registration.

The FlowExecutionResponse.type schema now accepts POLL. The existing allowed values remain unchanged.

Suggested reviewers: thamindur

Priority: Normal

Merge Risk: Minimal · up to f83e4

The change permits POLL responses without removing existing response types. No actionable merge-blocking issue is established; merge after normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the enum change and its device-registration use case, but it omits most required template sections, including purpose, goals, approach, checklist, release note, documentation,… Complete the required description template. Add the missing sections and mark non-applicable sections as N/A with a brief explanation.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: adding the POLL flow execution response type.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description explains the enum change and its device-registration use case, but it omits most required template sections, including purpose, goals, approach, checklist, release note, documentation, testing, security checks, and migration details.

Resolution

Complete the required description template. Add the missing sections and mark non-applicable sections as N/A with a brief explanation.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant