Skip to content

Javadoc and comment corrections for WKS format, SlhDsa, LMS verify, AES-CBC and Fips.DhAgree() - #301

Open
cconlon wants to merge 5 commits into
wolfSSL:masterfrom
cconlon:fenrirOct16_2
Open

Javadoc and comment corrections for WKS format, SlhDsa, LMS verify, AES-CBC and Fips.DhAgree()#301
cconlon wants to merge 5 commits into
wolfSSL:masterfrom
cconlon:fenrirOct16_2

Conversation

@cconlon

@cconlon cconlon commented Oct 16, 2026

Copy link
Copy Markdown
Member

This PR fixes 5 Fenrir issues:

  • F-15068: Document the WKS encodedEntry length wrapper.
  • F-15069: Correct the SlhDsa parameter set lifecycle Javadoc.
  • F-15070: Correct the LMS verify error mapping comment.
  • F-15083: Document the block-aligned AES-CBC update() length.
  • F-15082: Document the Fips.DhAgree() agree buffer size.

@cconlon cconlon self-assigned this Oct 16, 2026
Copilot AI balanced review requested due to automatic review settings October 16, 2026 18:20
Copilot AI reviewed Oct 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cconlon cconlon assigned rlm2002 and unassigned cconlon Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@rlm2002 rlm2002

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cconlon @rlm2002