Repository navigation
Conversation
emmartins
force-pushed
the
WFLY-19812-junit5
branch
from
October 1, 2026 03:41
6c905fd to
01e41b4
Compare
rhusar
reviewed
Oct 3, 2026
rhusar
left a comment
rhusar
left a comment
Member
There was a problem hiding this comment.
I forgot about quickstarts in the JUnit 6 epic https://redhat.atlassian.net/browse/WFLY-21566 but that's mainly about migration from 4->6 and most of this is from 5->6 it seems. can you please review that Jira for the migration path proposed and see if this is in line with the recommendations or object and discuss if it is not?
I can do a review of this in full if you want, but very roughly, this looks good to me.
Contributor
Author
|
This mostly changes asserts and Before/After, think that's fine wrt your JIRA. Feel free to review :) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://redhat.atlassian.net/browse/WFLY-19812