Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 0a6f769 (2026-09-29) added NULL checks for the Y/U/V planes of
vpx_ref_frame_tin the VP8 encoder handlers, but six sibling handlers accepting the same public struct were left unpatched:ctrl_set_reference,ctrl_copy_reference(vp9/vp9_cx_iface.c)ctrl_set_reference,ctrl_copy_reference(vp9/vp9_dx_iface.c)vp8_set_reference,vp8_get_reference(vp8/vp8_dx_iface.c)Passing a
vpx_ref_frame_twith NULL planes viavpx_codec_control()segfaults (SIGSEGV) in the VP9 encoder/decoder paths — verified with a PoC calling the real handlers (memcpy(dst, src=NULL, n=64)confirmed via interposer).This applies the same 5-line check already accepted upstream for the VP8 encoder to all six handlers, returning
VPX_CODEC_INVALID_PARAMinstead of crashing. Rebuilt and retested: handlers now return INVALID_PARAM, exit 0.