Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Reviewed the stack at 07b101a: ran the examples (WDIO mocha/Cucumber, Selenium, Nightwatch × telemetry/trace × retries ×
|
…ifacts manifest A manifest that lists only test states cannot link a run to the traces it produced or to a CI parent span. Each attempt now mints its trace and span id when it starts, and the manifest records the run id and any TRACEPARENT parent, so an external consumer can address every attempt. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
…m the real attempt A retried Selenium test was listed twice with final on its failed attempt, because the test uid carried a per-process counter the attempt ledger did not. A specFileRetries rerun recorded attempt 0, the tracker could renumber an attempt into a repeat, and only the final attempt kept its error. Artifact paths are now written relative to the manifest directory so a moved or downloaded results folder still resolves, and the manifest records cwd and browser identity for the exporter to slice by. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Winify
force-pushed
the
otel/1-manifest-trace-ids
branch
from
November 11, 2026 11:42
a528f4f to
ae35f19
Compare
Winify
marked this pull request as ready for review
November 11, 2026 11:42
A retried Mocha test now reuses its first attempt's uid so the artifacts manifest lists it once. The trace writer keyed a test's group on that uid, so in a zip holding more than one test both attempts merged into a single group and the examples smoke check counted one attempt where two ran. Selenium stamps the attempt on each row of a retried attempt and the group is keyed on the uid plus that attempt. A first attempt, and every adapter that sets no attempt, exports exactly as before. Also fixes the two test files that failed typecheck: a mock read through a plainly typed hook, and a WebdriverIO-shaped result passed as a literal to a parameter that deliberately omits the field the service ignores. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Part 1 of 4 of the OpenTelemetry export, replacing #485.
What
The artifacts manifest (
devtools-artifacts-<sessionId>.json) can now link a run to its traces:attempts[]list. The test's last attempt is markedfinal, so a consumer reading the manifest can tell a retried test from its earlier attempts.runIdand, when the run was launched under aTRACEPARENT, that parent context.specFileRetriesthefinalflag and the attempt number agree.Why
#485 created span ids when the manifest was uploaded, after the run ended. A test therefore had no id while it ran, so its span couldn't be linked live or carry a CI parent. Ids recorded when each attempt starts fix that. Pushing the same manifest again also gives the same spans.
Verification
pnpm build,pnpm test(3999 passed, 4 skipped),pnpm lint(0 errors) andpnpm docs:capabilities --checkpass on this branch.🤖 Generated with Claude Code