Repository navigation
db: invalidate copied pooled connection handles on release - #29792
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying a pooled
db.Conncopied its driver pointer while sharing its mutex. Releasing one copy left other copies able to use or return the physical connection after another borrower acquired it. Store the driver and mutex in shared private state so every copy becomes invalid together, and concurrent release/discard returns or closes the driver exactly once.Add stale-copy and concurrent-copy regressions and document the release behavior. This addresses a safety gap in the existing pooling API discussed in #27668; the remaining multi-phase proposal is outside this change.
Validation:
db: connection is released../v -cstrict -cc clang -silent test vlib/db/pool_test.v vlib/db/tx_test.v vlib/db/driver_test.vpassed (3/3)../v check-md vlib/db/README.md, andgit diff --checkpassed.Refs #27668.
Focused validation at
c4ef4adcc264after the upstream merges: all five DB files remain byte-identical to fix98eac560e538. Rebuilt the compiler after the first upstream compiler merge and passed strict Clang pool, transaction, and driver tests (3/3). The subsequent merge changed only doctor code/documentation and its fixture; the same three tests passed again with the compiler held stable. These checks use test drivers; live external database services were not exercised.