Repository navigation
PLR0914 part1 - #4579
Merged
Merged
PLR0914 part1#4579
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4579 +/- ##
==========================================
- Coverage 49.98% 49.96% -0.02%
==========================================
Files 151 151
Lines 30450 30127 -323
==========================================
- Hits 15220 15053 -167
+ Misses 15230 15074 -156 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
je-cook
force-pushed
the
PLR0914
branch
2 times, most recently
from
September 10, 2026 09:51
ef53162 to
29d1765
Compare
je-cook
marked this pull request as ready for review
September 30, 2026 14:07
je-cook
force-pushed
the
PLR0914
branch
2 times, most recently
from
October 5, 2026 14:37
dbba067 to
5515433
Compare
clmould
requested changes
Oct 8, 2026
clmould
left a comment
clmould
left a comment
Collaborator
There was a problem hiding this comment.
Mostly happy, just a few minor things!
je-cook
force-pushed
the
PLR0914
branch
2 times, most recently
from
October 9, 2026 08:02
b10b525 to
80b56a0
Compare
clmould
requested changes
Oct 9, 2026
Comment on lines
+2253
to
+2266
| axis, | ||
| fig, | ||
| rmajor, | ||
| rminor, | ||
| triang, | ||
| radius_plasma_core_norm, | ||
| kappa, | ||
| i_single_null, | ||
| plasma_square, | ||
| big_q_plasma, | ||
| p_fw_alpha_mw, | ||
| f_p_alpha_plasma_deposited, | ||
| p_neutron_total_mw, | ||
| pflux_plasma_surface_neutron_avg_mw, |
Collaborator
There was a problem hiding this comment.
Could these be typed and have brief descriptions in the docstring plz?
clmould
reviewed
Oct 9, 2026
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
clmould
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tackling (some of) PLR0914
Checklist
I confirm that I have completed the following checks: