Skip to content

Allow specifying a WS closing code to TemplatedApp.close() #1911

Description

@dragosnicolae

Hello,

As per documentation, the TemplatedApp.close() method "closes all sockets including listen sockets". For WS servers this means that all WS connections are closed without a closing code (I'm guessing the underlying TCP socket is the one that is actually closed) and the reported code is 1006.

It would be useful to have a way for specifying the WS closing code to send to the clients. This way, applications can identify and handle on the client side the situation of a server being closed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions