Repository navigation
Add Gemfile.lock lockfile-hygiene scan to pre-commit hook - #810
Merged
Merged
Conversation
Mirrors the gems-lockfile-hygiene CI gate locally: rewrites an internal Artifactory gem-mirror URL in a staged Gemfile.lock to rubygems.org before the commit lands, the same way twilio-node does for package-lock.json. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
rubocop's ConfigStore does a non-atomic `@path_cache[dir] ||= ...` read-modify-write (config_store.rb). --parallel runs worker threads via Parallel.in_threads, and JRuby's true parallel threads (no GIL) can expose that race, handing a thread a nil config path and crashing with "no implicit conversion of nil into String" in File.absolute_path when scanning examples/. CRuby's GIL happens to serialize the Hash access enough in practice to avoid it, which is why only the jruby-9.4 leg failed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
kridai
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gems-lockfile-hygieneCI gate locally: rewrites an internal Artifactory gem-mirror URL in a stagedGemfile.locktorubygems.orgbefore the commit lands, the same way twilio-node does forpackage-lock.json.githooks/pre-commitand the Makefilegithookstarget already existed onmain; this only adds the actual hygiene scan.Test plan
make testrun locally via the hook on commit (377 examples, 0 failures)Gemfile.lock🤖 Generated with Claude Code