Repository navigation
fix: name Swift Testing tests under their whole suite path again - #44
Merged
Merged
Conversation
Reverts b6d641d, restoring 0.5.1's code: a Swift Testing test in a nested suite is recorded, reported in unskippable.tsv and matched against the skip list under its whole suite path (`Outer/Inner`), outermost first, and the skip list still accepts lines that name only the innermost suite. The tests for nested suites (ten levels deep, in an extension, in an enum namespace) come back with it. Amp-Thread-ID: https://ampcode.com/threads/T-01a1da7c-b086-7013-bf61-bab1d2304b97 Co-authored-by: Eduardo Nunes <esnunes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Reverts #43 (b6d641d), so the code is 0.5.1's again (#42). Apart from the generated
CHANGELOG.md, the tree matches the0.5.1tag. Merging this releases 0.5.3 with 0.5.1's behavior:records.binand listed inunskippable.tsvunder its whole suite path (Outer/Inner), outermost first, separated by/. XCTest names don't change.Why
0.5.2 reverted these changes because Tuist's server on
mainstores test case runs under the innermost suite and matches per-test evidence bymodule␟suite␟name. Under whole-path names, tests in nested suites get no new evidence. This release ships the whole-path behavior as a fix so Tuist can adopt it alongside the server change that matches whole suite paths (tuist/tuist#15645).Impact
Until the server matches whole suite paths, a project that resolves 0.5.3 records no new per-test evidence for tests in nested suites. Coverage-based selection keeps using their last 0.5.0/0.5.2 version, as with 0.5.1. Nothing is wrongly skipped. Tuist's
Package.swiftuses.upToNextMinor(from: "0.5.2"), so itsPackage.resolvedstays on 0.5.2 until someone bumps it.Validation
git diff 0.5.1 -- . ':!CHANGELOG.md'is empty: the code is the same as 0.5.1, which passed CI when it was released.