Skip to content

fix: name Swift Testing tests under their whole suite path again - #44

Merged
esnunes merged 1 commit into
mainfrom
fix/reapply-whole-suite-paths
Nov 14, 2026
Merged

esnunes merged 1 commit into
mainfrom
fix/reapply-whole-suite-paths

Conversation

@esnunes

@esnunes esnunes commented Nov 14, 2026

Copy link
Copy Markdown
Member

What changed

Reverts #43 (b6d641d), so the code is 0.5.1's again (#42). Apart from the generated CHANGELOG.md, the tree matches the 0.5.1 tag. Merging this releases 0.5.3 with 0.5.1's behavior:

  • A Swift Testing test in a nested suite is recorded in records.bin and listed in unskippable.tsv under its whole suite path (Outer/Inner), outermost first, separated by /. XCTest names don't change.
  • The skip list takes a line's first component as the module, its last as the test and everything between as the suite. It also still skips a nested test when the line names only its innermost suite.
  • The tests for nested suites (ten levels deep, in an extension, in an enum namespace) come back.

Why

0.5.2 reverted these changes because Tuist's server on main stores test case runs under the innermost suite and matches per-test evidence by module␟suite␟name. Under whole-path names, tests in nested suites get no new evidence. This release ships the whole-path behavior as a fix so Tuist can adopt it alongside the server change that matches whole suite paths (tuist/tuist#15645).

Impact

Until the server matches whole suite paths, a project that resolves 0.5.3 records no new per-test evidence for tests in nested suites. Coverage-based selection keeps using their last 0.5.0/0.5.2 version, as with 0.5.1. Nothing is wrongly skipped. Tuist's Package.swift uses .upToNextMinor(from: "0.5.2"), so its Package.resolved stays on 0.5.2 until someone bumps it.

Validation

  • git diff 0.5.1 -- . ':!CHANGELOG.md' is empty: the code is the same as 0.5.1, which passed CI when it was released.
  • I didn't run the tests locally because this was done from a Linux sandbox. This PR's macOS CI runs them.

Reverts b6d641d, restoring 0.5.1's code: a Swift Testing test in a nested
suite is recorded, reported in unskippable.tsv and matched against the skip
list under its whole suite path (`Outer/Inner`), outermost first, and the skip
list still accepts lines that name only the innermost suite. The tests for
nested suites (ten levels deep, in an extension, in an enum namespace) come
back with it.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1da7c-b086-7013-bf61-bab1d2304b97
Co-authored-by: Eduardo Nunes <esnunes@gmail.com>
@esnunes
esnunes requested a review from a team as a code owner November 14, 2026 14:43
@esnunes
esnunes requested review from fortmarek and removed request for a team November 14, 2026 14:43
@esnunes
esnunes merged commit 1d14067 into main Nov 14, 2026
10 checks passed
@esnunes
esnunes deleted the fix/reapply-whole-suite-paths branch November 14, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants