Repository navigation
chore(deps): bump graph-selector to 0.15.1 - #847
Conversation
Moves the app from 0.14.0 and the api from 0.13.0 to 0.15.0. 0.15.0 parses large charts much faster: a 2000-line chart drops from 52.1 ms to 3.4 ms median, a 500-line chart from 3.2 ms to 1.1 ms. It also fixes parser state that leaked across lines. After a dedent, a deeper line could attach to a stale ancestor, so "a / b / c / d" with d indented three spaces drew b -> d instead of c -> d. Comment stripping is now done in-repo, which drops the strip-comments packages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Blocked: do not merge. graph-selector 0.15.0 freezes the page in production builds. The E2E I confirmed it in the paused frame on the preview. The wrapped regex returns groups ( The fix belongs in graph-selector. This PR then moves to the patched release. |
|
Fix: tone-row/graph-selector#65. I confirmed the freeze on a local |
0.15.0 froze the page in production builds. CRA's Babel wraps named-group regex literals, and a RegExp copied from one loses match.groups, which left getFeatureData looping forever. 0.15.1 keeps that regex a literal (tone-row/graph-selector#65). It also moves pkgroll to devDependencies, which drops its build toolchain from the lockfile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Moves the app (0.14.0) and the api (0.13.0) to graph-selector 0.15.1.
0.15.0 froze the page in production builds and is skipped. CRA's Babel wraps named-group regex literals, and a
RegExpcopied from one losesmatch.groups, sogetFeatureDatalooped forever. tone-row/graph-selector#65 fixed it in 0.15.1 and added a lint rule that rejects that pattern.What 0.15 brings
Faster parsing (graph-selector Export-Import JSON Graph #61). Measured on the published npm builds with graph-selector's own realistic-document generator (3 seeds, median of 15 runs):
Parser state no longer leaks across lines (Switch to monaco code editor #59). After a dedent, a deeper line could attach to a stale ancestor. A later reference could then come from the wrong node too. A
featuresRelastIndexleak could also drop#id/.class/[attr]on a later line.In-repo comment stripping (Update editor style; colors #62) replaces the
strip-commentsfork, so those packages leave the lockfile.Behavior change to know about
Charts with uneven indentation after a dedent now render the way they read. On the doc below, 0.14.0 drew
b -> dandd -> Start. 0.15.0 drawsc -> dandNext -> Start:This fixes a bug, but an existing chart that depended on the old wiring will look different.
Verification
On 0.15.1:
react-scripts build) and served it statically. The page loaded and stayed responsive on 4 of 4 loads. Published 0.15.0 froze on 4 of 4 under the same probe. The sandbox drive (below) also passes on this production build.pnpm -F api check,pnpm -F api test(22 passed),pnpm -F app check, andpnpm -F app test(715 passed) all pass.On 0.15.0 (the parser behavior is unchanged in 0.15.1):
pnpm -F api check,pnpm -F api test(22 passed),pnpm -F app check, andpnpm -F app test(715 passed) all pass.pnpm -F app visualpassed 11/11 (10 templates plus the references fixture)..classafter trailing text, dedent,(#id)and(Label)references, a container, and syntax highlighting. The run passed with no console errors, and I checked the screenshots.🤖 Generated with Claude Code