Skip to content

compiler: remove invalid pragmas from test fixture #5894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deadprogram merged 1 commit into from
Oct 19, 2026
+0 −6
Merged

compiler: remove invalid pragmas from test fixture #5894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions compiler/testdata/pragma.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,6 @@ func foobarImport()
func foobarExportModule() {
}

// This function should not: it's only a declaration and not a definition.
//
//go:section .special_function_section
func undefinedFunctionNotInSection()

//go:section .special_global_section
Expand All @@ -116,9 +113,6 @@ var multipleGlobalPragmas uint32
//go:noescape
func doesNotEscapeParam(a *int, b []int, c chan int, d *[0]byte)

// The //go:noescape pragma only works on declarations, not definitions.
//
//go:noescape

@jakebailey jakebailey Oct 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, why does this have to be removed? (Not that I know why this was there in the first place)

@davecheney davecheney Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a PR coming which will validate pragmas better; it started from the //go:nolinktime PR, but I spotted that other pragmas could validate their arguments sooner and spot invalid use rather than silently being ignored

func stillEscapes(a *int, b []int, c chan int, d *[0]byte) {
}

Expand Down
Loading