Repository navigation
Add modern rule set grouping trait/reference/dynamic-name rules - #360
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groups 5 rules that modern/legacy-heavy codebases violate in bulk into a dedicated
modernset, so a project can enable or disable them with a single toggle instead of per-rule ignores.Moved into new
config/modern-rules.neon, gated by%symplify.modern%:ForbiddenTraitRule(was inconfigurable)ForbiddenExtendOfNonAbstractClassRule(was instatic)NoReferenceRule(was instatic)NoDynamicNameRule(was incomplexity)ForeachCeptionRule(was incomplexity)moderndefaults totrue, so default enforcement is unchanged. Projects flipsymplify.modern: falseto disable the whole group.Registered in both
symplify-rules.neonandcomposer.jsonextension includes; schema + README updated.