Add a hook to customise client connection pipeline in tests - #144
Merged
aryan-25 merged 4 commits intoOct 2, 2026
Merged
Conversation
FranzBusch
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There are two tests in
HTTP3DatagramTestswhich set up a client-server connection and test for reading/writing unreliable datagrams on the connection.The client handler in these tests immediately starts writing datagrams without waiting for the server's SETTINGS frame to arrive. If the write happens to occur before the SETTINGS arrive, the underlying swift-nio-http3 stack drops the write. This results in the test hanging until the connection idle timeout closes the connection, at which point all
#expect/#requireassertions fail.We have run into this race in some CI runs over the past few days.
Modifications
additionalConnectionChannelInitializertoTestHelpers.ClientConfiguration. This can be used to add additional handlers to the connection pipeline in tests.Result
The affected tests in
HTTP3DatagramTestsare now more reliable.