Move graceful shutdown configuration - #140
Merged
gjcairo merged 4 commits intoSep 30, 2026
Merged
Conversation
FranzBusch
approved these changes
Sep 23, 2026
gjcairo
approved these changes
Sep 25, 2026
gjcairo
enabled auto-merge (squash)
September 30, 2026 12:50
Collaborator
|
API breakage is expected, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, graceful shutdown configuration is nested in the HTTP/2 configuration. This should not be the case; the configuration should live at the top level as graceful shutdown applies over all HTTP versions.
Modifications
Moved graceful shutdown configuration out of the HTTP/2 configuration and into the top level.
Result
Better API.