Skip to content

feat(shopify): expand operations and refresh expiring credentials - #8833

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/shopify-review-completion
Oct 9, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/shopify-review-completion

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Expand Shopify from 21 to 28 operations with bulk variant management, fulfillment-order lookup, tracking updates, and cancellation-job polling. Preserve existing list defaults and response fields while adding optional inputs, pagination, and detail outputs.
  • Align requests with Admin GraphQL 2026-10, including inventory preconditions and idempotency, partial-update errors, cancellation outcomes, and credential-bound shop domains.
  • Support expiring offline credentials with serialized installation-wide refresh and reconnects that preserve existing account links and legacy non-expiring credentials.
  • Preserve explicit empty updates, ignore hidden numeric inputs from other operations, omit unsupplied tracking, and align nullable output metadata and generated field documentation. Preserve caller cancellation through OAuth response consumption.
  • Keep expanded order-update responses opt-in so existing service-account scopes remain sufficient. Match array field assistance to JSON-array inputs and make bulk variant output contracts precise.

Type of Change

  • Feature
  • Bug fix

Testing

Final validation against Shopify's official documentation and 2026-10 schema passed 349 request scenarios, 601 response cases, 87 compatibility probes, 1,237 block/input checks, and 475 documentation-property checks. Passed 129 focused tests, 17 PostgreSQL/HTTP integration tests, all 58 repository audits, all 26 workspace type checks, lint, docs manifest, block registry, and actionlint. New regression tests were demonstrated failing before their fixes.

Passed the full script suite (409 tests) and all 19 workspace test suites (20 successful Turbo tasks) (39,200 tests, including 36,877 app tests). Used one script worker, four workspace workers, and a 30-second test timeout after host-load timeouts; no assertions were disabled. The reconnect integration case includes a real pending draft. Shopify provider behavior is tested with a local HTTP fixture, not a live store.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 9, 2026 4:48am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 48 files

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/shopify/list_orders.ts
Comment thread apps/sim/tools/shopify/get_customer.ts
Comment thread apps/sim/tools/shopify/create_customer.ts
Comment thread apps/sim/tools/shopify/update_customer.ts
Comment thread apps/sim/lib/oauth/shopify.integration.ts Outdated
Comment thread apps/sim/tools/shopify/create_fulfillment.ts Outdated
Comment thread apps/sim/tools/shopify/get_fulfillment_order.ts
Comment thread apps/sim/tools/shopify/get_job.ts
Comment thread apps/sim/tools/shopify/list_fulfillment_orders.ts
Comment thread apps/sim/tools/shopify/types.ts Outdated
@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[High impact] The PR appears safe to merge; no new blocking issue remains.

Summary

Expands Shopify from 21 to 28 operations and adds shared refresh support for expiring offline credentials.

  • Adds bulk variant changes, fulfillment lookup, tracking updates, and cancellation-result polling.
  • Adds pagination, optional detail responses, and inventory safeguards.
  • Keeps expanded order-update responses opt-in and aligns array assistance and bulk variant output definitions.
  • The five previous unnumbered findings are addressed. No new actionable issue was established.

Diagram

sequenceDiagram
  participant Caller
  participant Sim
  participant DB as Postgres
  participant Shopify
  Caller->>Sim: Connect or refresh Shopify credentials
  Sim->>DB: Acquire installation lock
  Sim->>DB: Read saved account
  Sim->>Shopify: Exchange code or refresh token
  Shopify-->>Sim: New token pair and expiry dates
  Sim->>DB: Update accounts for the same shop
  Sim->>DB: Commit and release lock
  Sim-->>Caller: Connected account or access token
Loading

Reviews (3) · Last reviewed commit: "fix(shopify): preserve scoped order upda..." · Reviewed by Greptile

Comment thread apps/sim/blocks/blocks/shopify.ts Outdated
Comment thread apps/sim/blocks/blocks/shopify.ts Outdated
Comment thread apps/sim/tools/shopify/create_fulfillment.ts Outdated
Comment thread apps/docs/content/docs/integrations/shopify.mdx
Comment thread apps/sim/tools/shopify/types.ts
@waleedlatif1
waleedlatif1 force-pushed the codex/shopify-review-completion branch from 02268bb to 6df0bb7 Compare October 9, 2026 04:04
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 49 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/oauth/shopify-installation.ts
Comment thread apps/sim/tools/shopify/get_fulfillment_order.ts
Comment thread apps/sim/lib/oauth/shopify-installation.ts
Comment thread apps/sim/tools/shopify/update_product_variants.ts Outdated
Comment thread apps/sim/lib/oauth/shopify.integration.ts
Comment thread apps/sim/tools/shopify/types.ts
Comment thread apps/sim/blocks/blocks/shopify.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 49 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/shopify/update_order.ts
Comment thread apps/sim/tools/shopify/types.ts
@waleedlatif1
waleedlatif1 merged commit 4308631 into staging Oct 9, 2026
47 of 48 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/shopify-review-completion branch October 9, 2026 05:00

This branch was successfully deployed

1 active deployment
Preview — 90c59ce5 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant