fix(settings): decouple access settings from usage analytics by waleedlatif1 · Pull Request #8828 · simstudioai/sim

waleedlatif1 · 2026-10-09T01:42:46Z

Summary

Keep permission groups independent of usage analytics and preserve unsaved settings during failed background reads.
Read organization plans, usable Enterprise access, and canonical seat reservations from primary through one authorized billing domain for SSO, members, and invitations.
Retry transient ledger reads in fresh read-only transactions with a shared retry/statement budget. Deduct pool wait at acquisition and reject expired reads before starting the ledger query. Return sanitized 503 responses with Retry-After for known temporary read failures.
Use plain neutral read-error text across workspace and organization settings, preserve accessible alerts and retry controls, and update the shared settings guide.
Remove unused billing queries, optimistic cache handling, exports, and a mock-only routing test. Preserve billing statistics for their remaining consumers. Use one named plan/seat response shape and type across the contract, query, and cache-isolation fixtures.

Type of Change

Bug fix

Testing

GitHub Actions runs the full test suite, PostgreSQL integration matrix, E2E suites, build, lint, type-check, and audits. Integration coverage includes authorization and tenant denial, canonical seat accounting, unusable Enterprise access, failed reads, fresh transaction retries, read-only enforcement, exhausted pool-wait budgets, and sanitized HTTP errors. Initial regression cases failed on the old behavior or with guards removed. Follow-up tests run in CI as requested.

Local source validation: lint, type-check, all 58 audits, docs manifest, block registry, generated artifacts, and pinned actionlint. Earlier UI verification produced 14 captured states and five recovery flows using production components with synthetic session/API data. The refreshed live component gallery shows the neutral styling and supports manual failure/recovery checks. All nine cleanup passes reviewed the full PR diff.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Full CI test suite passing on the final commit
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-10-09T01:42:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 9, 2026 4:22am UTC

cubic-dev-ai

All reported issues were addressed across 39 files

_{Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-10-09T01:48:39Z

Confidence Score: 5/5

[High impact] The reviewed changes appear safe to merge; no actionable issue remains.

Summary

Separates access settings from usage analytics and adds primary-backed organization plan and seat reads. The latest changes consolidate the response schema and reuse its named type in the query and fixtures.

No new actionable issues found.
The expired-budget guard now rejects the read before its query starts. waleedlatif1 accepted delayed connection acquisition because Drizzle cannot cancel queued acquisition without leaving a transaction running.
The exported query APIs have TSDoc.
greptile-apps[bot] dismissed the standalone-schema export finding: the contract exposes the validator, and a separate unused export would conflict with repository rules.
waleedlatif1 intentionally kept the freshness constant private: the hook and warmer share organizationPlanSeatsOptions, while exporting the constant separately would add an unused export.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[SSO, members, invitations] --> B[Shared plan and seat query]
  B --> C[Authorized billing-plan route]
  C --> D[Current organization admin or owner check]
  D --> E[Primary database plan and seat reads]
  F[Permission group settings] --> G[Permission group query]
  H[Billing statistics] --> I[Usage ledger reads]

_{Reviews (6) · Last reviewed commit: "refactor(settings): share the named plan..." · Reviewed by Greptile}

waleedlatif1 · 2026-10-09T02:35:27Z

@greptile

waleedlatif1 · 2026-10-09T02:35:28Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T02:35:34Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 39 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-09T03:43:03Z

@greptile

waleedlatif1 · 2026-10-09T03:43:04Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T03:43:10Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 39 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-09T04:03:05Z

@greptile

waleedlatif1 · 2026-10-09T04:03:06Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T04:03:12Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 73 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-09T04:22:18Z

@greptile

waleedlatif1 · 2026-10-09T04:22:21Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T04:22:26Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 73 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-09T04:29:32Z

@greptile

waleedlatif1 · 2026-10-09T04:29:33Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T04:29:40Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 73 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread apps/sim/lib/billing/core/ledger-read.ts

Comment thread apps/sim/lib/api/server/routes/billing-read.ts Outdated

vercel Bot deployed to Preview October 9, 2026 01:47 View deployment

greptile-apps Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread apps/sim/lib/billing/core/ledger-read.ts

vercel Bot temporarily deployed to Preview October 9, 2026 02:35 Inactive

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread apps/sim/lib/billing/core/ledger-read.ts

waleedlatif1 force-pushed the codex/settings-billing-read-resilience branch from 6065401 to a9775db Compare October 9, 2026 03:42

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread apps/sim/hooks/queries/organization-plan-seats.ts

vercel Bot deployed to Preview October 9, 2026 03:49 View deployment

waleedlatif1 added 4 commits October 8, 2026 20:56

fix(settings): decouple access settings from usage analytics

4a5dae8

fix(billing): refuse expired reads and recover transaction timeouts

e4865ab

chore(settings): simplify ledger fixture and correct plan documentation

5321343

fix(settings): use neutral read-error feedback consistently

5c2c9d1

waleedlatif1 force-pushed the codex/settings-billing-read-resilience branch from a9775db to 5c2c9d1 Compare October 9, 2026 04:02

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread apps/sim/ee/session-policy/components/session-policy-settings.tsx

vercel Bot deployed to Preview October 9, 2026 04:07 View deployment

greptile-apps Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread apps/sim/lib/api/contracts/organization.ts Outdated

refactor(settings): share the named plan and seat response type

05a1d5a

vercel Bot temporarily deployed to Preview October 9, 2026 04:22 Inactive

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread apps/sim/hooks/queries/organization-plan-seats.ts

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

waleedlatif1 merged commit f20b5b4 into staging Oct 9, 2026
47 of 48 checks passed

waleedlatif1 deleted the codex/settings-billing-read-resilience branch October 9, 2026 04:32

waleedlatif1 mentioned this pull request Oct 9, 2026

v0.9.17: tables ledger, oracle integrations, mship improvements #8853

Merged

Conversation

waleedlatif1 commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

waleedlatif1 commented Oct 9, 2026 •

edited

Loading

vercel Bot commented Oct 9, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Oct 9, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading