Skip to content

feat(dashboards): add empty-state graphic for the dashboard page - #8719

Open
TheodoreSpeaks wants to merge 1 commit into
stagingfrom
feat/cool-diagrams
Open

TheodoreSpeaks wants to merge 1 commit into
stagingfrom
feat/cool-diagrams

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Added a drawn empty-state graphic for the dashboard page — a stat tile, a donut tile, and a trend panel fading off the corner — matching the tables/files/knowledge/logs set (same hairline, ink mixes, and corner fade)
  • DashboardEmptyState lives with the other resource empty states and replaces the bare EmptyState in dashboard-resource.tsx; copy unchanged

Type of Change

  • New feature

Testing

  • Rendered the real component in light and dark next to the existing empty states
  • bun run lint, check:audits (58/58), block-registry check, docs-manifest:check
  • components/dashboards tests pass; root bun run test shows unrelated local failures only (env-dependent rate-limit/timeout tests and load timeouts) — type-check left to CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

https://claude.ai/code/session_01J7A6CWpREr1jiPAdWyTQbA

@vercel

vercel Bot commented Oct 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 7, 2026 2:49am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Low risk] Adds a custom empty-state graphic for dashboards.

No behavioral failure was found, but the props-interface and constant-array requirements must be satisfied before merging.

Findings

  1. P2 Components lack required props interfaces ▶
  2. P2 Fixed chart points remain mutable ▶

Summary

Adds a dashboard illustration with a stat tile, donut chart, and trend panel.

  • Uses DashboardEmptyState in the existing empty branch without changing the copy.
  • Preserves loading, error, preview, and feature-access behavior.
  • Two repository requirements need attention: props interfaces and readonly chart constants.

Reviews (1) · Last reviewed commit: "feat(dashboards): add empty-state graphi..." · Reviewed by Greptile

}

/** Empty state for a workspace whose dashboard Sim has not built yet. */
export function DashboardEmptyState() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Components lack required props interfaces

DashboardEmptyState and DashboardGraphic omit props interfaces. The component guide requires a props interface for every component. Add named interfaces for both components to satisfy this repository requirement before merging.

Context Used: Component patterns and structure for React components (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


type Point = readonly [number, number]

const SPARKLINE: Point[] = [

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Fixed chart points remain mutable

SPARKLINE and TREND are fixed drawing data but use mutable Point[] arrays. CLAUDE.md requires as const for constant arrays. Mark both arrays as const and let toPath accept a readonly array. This prevents accidental coordinate changes and satisfies the repository requirement before merging.

Context Used: CLAUDE.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

This branch was previously deployed

1 inactive deployment
Preview — e6a282cb Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant