Repository navigation
feat(dashboards): add empty-state graphic for the dashboard page - #8719
TheodoreSpeaks wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
| } | ||
|
|
||
| /** Empty state for a workspace whose dashboard Sim has not built yet. */ | ||
| export function DashboardEmptyState() { |
There was a problem hiding this comment.
Components lack required props interfaces
DashboardEmptyState and DashboardGraphic omit props interfaces. The component guide requires a props interface for every component. Add named interfaces for both components to satisfy this repository requirement before merging.
Context Used: Component patterns and structure for React components (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
|
||
| type Point = readonly [number, number] | ||
|
|
||
| const SPARKLINE: Point[] = [ |
There was a problem hiding this comment.
Fixed chart points remain mutable
SPARKLINE and TREND are fixed drawing data but use mutable Point[] arrays. CLAUDE.md requires as const for constant arrays. Mark both arrays as const and let toPath accept a readonly array. This prevents accidental coordinate changes and satisfies the repository requirement before merging.
Context Used: CLAUDE.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
DashboardEmptyStatelives with the other resource empty states and replaces the bareEmptyStateindashboard-resource.tsx; copy unchangedType of Change
Testing
bun run lint,check:audits(58/58), block-registry check,docs-manifest:checkcomponents/dashboardstests pass; rootbun run testshows unrelated local failures only (env-dependent rate-limit/timeout tests and load timeouts) — type-check left to CIChecklist
test-auditauthoring gate)🤖 Generated with Claude Code
https://claude.ai/code/session_01J7A6CWpREr1jiPAdWyTQbA