fix(webhooks): skip duplicate webhook deliveries already in progress instead of polling by waleedlatif1 · Pull Request #8712 · simstudioai/sim

waleedlatif1 · 2026-10-07T01:12:30Z

Summary

A duplicate webhook delivery whose idempotency key is already in progress used to poll every second until the original run finished (up to the 2h lease), holding a worker, a queue slot, and its usage reservation, even though nothing reads the duplicate job's result. It now returns immediately as a duplicate no-op and releases its reservation through the existing not-started path
Add executeOrSkipInProgress to the idempotency service (separate method, discriminated resolved | in-progress result) instead of an option, so a skipped duplicate can never be mistaken for an undefined result. executeWithIdempotency is unchanged for every other caller — Stripe billing webhooks and the polling triggers keep waiting (Stripe must not 2xx before the first attempt settles; polling counts gate cursor advancement)

Type of Change

Bug fix

Testing

New failure-mode tests, each shown red by reverting its guard: skip resolves without polling or running the operation; skip still replays completed and rethrows failed; webhook job returns duplicate without preprocessing/requeue and releases the slot once. A wait-path test guards that the default still waits (goes red if the default flips to skip)
bun run --cwd apps/sim test on idempotency, webhook-execution, and polling suites
bun run lint, bun run type-check, bun run check:audits — green

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…lling claim lease

vercel · 2026-10-07T01:12:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 7, 2026 1:59am UTC

cubic-dev-ai

All reported issues were addressed across 4 files

_{Fix all with cubic | Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-10-07T01:18:02Z

Confidence Score: 5/5

[High risk] Changes webhook delivery deduplication and idempotency polling.

The PR appears safe to merge, with no new actionable findings.

Summary

Webhook jobs now skip deliveries whose idempotency key is already in progress and release the duplicate job's reservation. Other callers keep waiting for the original result.

Adds executeOrSkipInProgress with separate resolved and in-progress outcomes.
Adds tests for skipping duplicates, replaying results, and preserving the default wait.
The only change since the previous review clarifies the lease limit in the documentation.
The earlier polling finding is fixed: pollingIdempotency no longer has the proposed five-minute lease. waleedlatif1 deferred bounding that lease to a separate change with renewal.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Webhook job] --> B[executeOrSkipInProgress]
  B --> C{Claim state}
  C -->|New claim| D[Run operation and save outcome]
  C -->|Completed| E[Replay saved result]
  C -->|Failed| F[Throw saved error]
  C -->|In progress| G[Release duplicate reservation]
  G --> H[Return duplicate no-op]

_{Reviews (6) · Last reviewed commit: "docs(idempotency): reflow executeWithIde..." · Reviewed by Greptile}

…e not bounded by the route

waleedlatif1 · 2026-10-07T01:27:34Z

@greptile

waleedlatif1 · 2026-10-07T01:27:35Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-07T01:27:39Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 4 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

… of overloading on policy

waleedlatif1 · 2026-10-07T01:36:35Z

@greptile

waleedlatif1 · 2026-10-07T01:36:36Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-07T01:36:41Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 5 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-07T01:41:13Z

@greptile

waleedlatif1 · 2026-10-07T01:41:14Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-07T01:41:20Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 5 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Turn on auto-fix | Re-trigger cubic}

…esult TTL

waleedlatif1 · 2026-10-07T01:59:28Z

@greptile

waleedlatif1 · 2026-10-07T01:59:29Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-07T01:59:34Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-10-07T01:59:42Z

@greptile

waleedlatif1 · 2026-10-07T01:59:43Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-07T01:59:48Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 5 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

fix(webhooks): skip duplicate in-progress deliveries and bound the po…

f90b277

…lling claim lease

vercel Bot temporarily deployed to Preview October 7, 2026 01:12 Inactive

cubic-dev-ai Bot reviewed Oct 7, 2026

View reviewed changes

Comment thread apps/sim/lib/core/idempotency/service.ts Outdated

greptile-apps Bot reviewed Oct 7, 2026

View reviewed changes

Comment thread apps/sim/lib/core/idempotency/service.ts Outdated

fix(webhooks): drop the polling lease change; detached poll passes ar…

7541702

…e not bounded by the route

vercel Bot temporarily deployed to Preview October 7, 2026 01:24 Inactive

cubic-dev-ai Bot reviewed Oct 7, 2026

View reviewed changes

refactor(idempotency): return the in-progress wait as a thunk instead…

60cdc34

… of overloading on policy

vercel Bot deployed to Preview October 7, 2026 01:37 View deployment

cubic-dev-ai Bot reviewed Oct 7, 2026

View reviewed changes

chore(idempotency): log the skipped duplicate once, at the caller

6133179

vercel Bot temporarily deployed to Preview October 7, 2026 01:41 Inactive

cubic-dev-ai Bot reviewed Oct 7, 2026

View reviewed changes

Comment thread apps/sim/lib/core/idempotency/service.ts Outdated

docs(idempotency): describe dedup as bounded by the claim lease and r…

6ecdd59

…esult TTL

vercel Bot temporarily deployed to Preview October 7, 2026 01:59 Inactive

docs(idempotency): reflow executeWithIdempotency TSDoc

75b711d

vercel Bot temporarily deployed to Preview October 7, 2026 01:59 Inactive

cubic-dev-ai Bot reviewed Oct 7, 2026

View reviewed changes

waleedlatif1 changed the title ~~fix(webhooks): skip duplicate in-progress deliveries and bound the polling claim lease~~ fix(webhooks): skip duplicate webhook deliveries already in progress instead of polling Oct 7, 2026

waleedlatif1 merged commit ccce7f7 into staging Oct 7, 2026
34 checks passed

waleedlatif1 deleted the fix/webhook-duplicate-skip branch October 7, 2026 02:16

waleedlatif1 mentioned this pull request Oct 7, 2026

v0.9.15: mship improvements, memory improvements, nextjs bump, plane and ramp integrations, outbox hardening #8748

Merged

Conversation

waleedlatif1 commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 7, 2026

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

waleedlatif1 commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 7, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Oct 7, 2026 •

edited

Loading

vercel Bot commented Oct 7, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Oct 7, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading