fix(chat): label simple effort options with the effort they send - #8619
Merged
Merged
Conversation
The simple Chat effort picker labeled medium as Low, high as Medium, and xhigh as High. Derive its options from MOTHERSHIP_EFFORT_OPTIONS so each label names the effort it sends: Medium, High, Extra High. Values, the default (high), and the stored preference are unchanged.
Collaborator
Author
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Contributor
|
Collaborator
Author
|
Label-only change, verified: the picker values are unchanged (medium / high / xhigh), the default still sends |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The simple Chat effort picker (shown when the advanced model selector is off) labeled each effort one step lower than the effort it sends:
mediumhigh(default)xhighThis is a label-only change: zero behaviour change, and the default still sends
high. A user who never touched the setting sends exactly what they sent before; the picker now reads "High" instead of "Medium".Design
MOTHERSHIP_SIMPLE_EFFORT_OPTIONSis now derived by filteringMOTHERSHIP_EFFORT_OPTIONStomedium,highandxhigh, so the simple picker uses the same label for an effort as the advanced picker and the Sim Chat block. The two lists can no longer drift apart.Compatibility
Every consumer was checked:
model-selector.tsx(Chat composer): the only reader ofMOTHERSHIP_SIMPLE_EFFORT_OPTIONS. It rendersoption.labeland sendsoption.value; the values are unchanged.resolveMothershipModelSettings: untouched. It still defaults tohighand still clampslow→mediumandmax→xhighwhen the simple picker is shown.stores/mothership-effort): stores the effort value, never the label, so saved selections are unaffected.blocks/blocks/mothership.ts): usesMOTHERSHIP_EFFORT_OPTIONS, which already labeled each effort honestly. Unchanged.Test plan
stores/mothership-effortand composer tests passbun run lint,bun run type-check,bun run check:audits,bun run docs-manifest:check, block-registry check againstorigin/stagingbun run testvia CI (Lint and Test, PostgreSQL integration, end-to-end): green. Locally the suite only timed out under unrelated machine load