Skip to content

fix(chat): label simple effort options with the effort they send - #8619

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/chat-effort-labels
Oct 5, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/chat-effort-labels

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The simple Chat effort picker (shown when the advanced model selector is off) labeled each effort one step lower than the effort it sends:

Sends Old label New label
medium Low Medium
high (default) Medium High
xhigh High Extra High

This is a label-only change: zero behaviour change, and the default still sends high. A user who never touched the setting sends exactly what they sent before; the picker now reads "High" instead of "Medium".

Design

MOTHERSHIP_SIMPLE_EFFORT_OPTIONS is now derived by filtering MOTHERSHIP_EFFORT_OPTIONS to medium, high and xhigh, so the simple picker uses the same label for an effort as the advanced picker and the Sim Chat block. The two lists can no longer drift apart.

Compatibility

Every consumer was checked:

  • model-selector.tsx (Chat composer): the only reader of MOTHERSHIP_SIMPLE_EFFORT_OPTIONS. It renders option.label and sends option.value; the values are unchanged.
  • resolveMothershipModelSettings: untouched. It still defaults to high and still clamps low→medium and max→xhigh when the simple picker is shown.
  • Persisted preference (stores/mothership-effort): stores the effort value, never the label, so saved selections are unaffected.
  • Sim Chat block (blocks/blocks/mothership.ts): uses MOTHERSHIP_EFFORT_OPTIONS, which already labeled each effort honestly. Unchanged.
  • Docs and tests: no page or test refers to the simple picker's labels.

Test plan

  • stores/mothership-effort and composer tests pass
  • bun run lint, bun run type-check, bun run check:audits, bun run docs-manifest:check, block-registry check against origin/staging
  • bun run test via CI (Lint and Test, PostgreSQL integration, end-to-end): green. Locally the suite only timed out under unrelated machine load

The simple Chat effort picker labeled medium as Low, high as Medium, and
xhigh as High. Derive its options from MOTHERSHIP_EFFORT_OPTIONS so each
label names the effort it sends: Medium, High, Extra High. Values, the
default (high), and the stored preference are unchanged.
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@vercel

vercel Bot commented Oct 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 5, 2026 8:50am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Changes labels on effort selection UI options.

The PR appears safe to merge.

Summary

The simple Chat effort picker now derives its options from the shared effort list.

  • The displayed labels become Medium, High, and Extra High for the existing medium, high, and xhigh values.
  • The default and sent effort values remain unchanged.

Reviews (1) · Last reviewed commit: "fix(chat): label simple effort options w..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Label-only change, verified: the picker values are unchanged (medium / high / xhigh), the default still sends high, and the only reader of these labels (model-selector.tsx) sends the value. Nothing that reaches the model changes, so there is no behavior to benchmark.

@waleedlatif1
waleedlatif1 merged commit dc10d4c into staging Oct 5, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/chat-effort-labels branch October 5, 2026 16:15

This branch was previously deployed

1 inactive deployment
Preview — d683172d Deployed Oct 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant