Skip to content

fix(code-placeholders): make python bare-placeholder classification and tagged-template edits linear - #8611

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/placeholder-scan-linear-followups
Oct 4, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/placeholder-scan-linear-followups

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Python bare-placeholder classification answers its line-prefix rules from a per-file offset index instead of running regexes over the prefix for every placeholder
  • Tagged-template nested edits are selected by bisection instead of a full scan per span
  • Output is unchanged

Type of Change

  • Bug fix

Testing

  • Differential fuzz against the previous implementation: ~790k classifier calls and ~70k full compiles, identical output; mutation checks confirm the fuzz catches boundary changes
  • Root bun run test, lint, type-check, check:audits, docs-manifest:check, block registry check

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

@vercel

vercel Bot commented Oct 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 4, 2026 6:14pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Refactors code placeholder parsing for Python and JavaScript.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR replaces repeated Python line-prefix classification with a per-file offset index and selects tagged-template nested edits by bisection. No new actionable issue was established.

Reviews (2) · Last reviewed commit: "fix(code-placeholders): make python bare..."

Comment thread apps/sim/lib/execution/code-placeholders/python.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit fa4980a into staging Oct 4, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/placeholder-scan-linear-followups branch October 4, 2026 18:28

This branch was previously deployed

1 inactive deployment
Preview — 54df17aa Deployed Oct 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant