Avoid linking rows with NULL primary keys - #2965
Open
sb123sb123 wants to merge 1 commit into
Open
sb123sb123 wants to merge 1 commit into
sb123sb123 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
None.Fixes #2145
Validation
uv run --python 3.13 --group dev pytest -q tests/test_table_html.py: 109 passed on macOS.ruff check tests/test_table_html.py datasette/views/table.py: passed.black --check --target-version py310 tests/test_table_html.py datasette/views/table.py: passed.The same full test module hit temporary-directory cleanup errors when run on the separate Windows G-drive environment (97 passed, 12 failed, 1 error); the isolated failure was also reproducible in the unchanged
test_table_cell_truncationtest. The complete module passes on macOS.