Conversation
Add ossl_cmp_log_cb() and ossl_cmp_log_console_cb() functions to wrap LOG() and LOG_console() calls with the correct signature expected by OSSL_CMP_CTX_set_log_cb(). This eliminates unsafe casts that relied on implicit conversion between incompatible function pointer types (int vs. bool return values and different parameter handling).
DDvO
force-pushed
the
fix_cast_incompatible
branch
from
September 28, 2026 08:13
4773c13 to
198dbc8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ossl_cmp_log_cb() and ossl_cmp_log_console_cb() functions to wrap LOG() and LOG_console() calls with the correct signature expected by OSSL_CMP_CTX_set_log_cb(). This eliminates unsafe casts that relied on implicit conversion between incompatible function pointer types (int vs. bool return values and different parameter handling).
Motivation
(Please write out your motivation here.)
Proposed Changes
(Write out the details of your proposed changes here.)
Test Plan
(Please provide clear instructions on how to verify that your changes work.)