Repository navigation
[#60] Update gpgme to 0.11 - #61
Merged
Merged
Conversation
heitor-lassarote
force-pushed
the
heitor-lassarote/#60-gpgme-0.11
branch
from
September 25, 2026 22:14
1d3786f to
a8c52b1
Compare
heitor-lassarote
marked this pull request as ready for review
September 25, 2026 22:29
heitor-lassarote
force-pushed
the
heitor-lassarote/#60-gpgme-0.11
branch
from
September 28, 2026 14:16
a8c52b1 to
6713611
Compare
heitor-lassarote
force-pushed
the
heitor-lassarote/#60-gpgme-0.11
branch
from
September 28, 2026 18:02
6713611 to
4e7a050
Compare
Member
Author
|
Reopening to retrigger CI — the check never fired for the latest push. |
Martoon-00
approved these changes
Oct 9, 2026
Martoon-00
left a comment
Martoon-00
left a comment
Member
There was a problem hiding this comment.
Thanks for leaving notes for reviewers, they are handy.
heitor-lassarote
force-pushed
the
heitor-lassarote/#60-gpgme-0.11
branch
from
October 9, 2026 16:38
4e7a050 to
b82a123
Compare
heitor-lassarote
force-pushed
the
heitor-lassarote/#60-gpgme-0.11
branch
from
October 14, 2026 13:39
b82a123 to
8fb1108
Compare
Base automatically changed from
heitor-lassarote/#56-upstream-ssh2-config
to
master
October 14, 2026 13:48
Problem: `gpgme` 0.10 depends on `gpgme-sys` 0.10 and `libgpg-error-sys` 0.5, whose build scripts run `gpgme-config` and `gpg-error-config`. Current gpgme and libgpg-error no longer ship these scripts, so update-daemon does not build outside Nix on such systems. Solution: update `gpgme` to 0.11, whose build scripts use `pkg-config` through `system-deps`. The functions update-daemon calls are unchanged in 0.11, apart from formatting. The lockfile also picks up `system-deps` and its dependencies, and newer `indexmap` and `hashbrown` versions, which `toml_edit` needs.
heitor-lassarote
force-pushed
the
heitor-lassarote/#60-gpgme-0.11
branch
from
October 14, 2026 13:48
8fb1108 to
69469d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
gpgmefrom 0.10 to 0.11. Its-syscrates find gpgme and libgpg-error throughpkg-config, so update-daemon builds outside Nix on systems whose gpgme and libgpg-error no longer shipgpgme-configandgpg-error-config.This is stacked on #59: the new lockfile needs Rust 1.85 or newer, and
masterpins 1.77.1. Once #59 is merged, this PR's base becomesmaster.Related issue(s)
Resolves #60
Notes for reviewers
gpgmefunctions update-daemon calls (Context::from_protocol,get_secret_key,add_signer,set_armorandsign_detached) are unchanged in 0.11, apart from formatting.gpg --verifyaccepts.nix build, which now runs the tests and pedantic clippy, passes.