Repository navigation
Release 1.0.0 on crates.io - #408
Merged
Merged
Conversation
heitor-lassarote
marked this pull request as ready for review
October 15, 2026 15:04
Martoon-00
reviewed
Oct 16, 2026
Martoon-00
left a comment
Martoon-00
left a comment
Member
There was a problem hiding this comment.
Two optional suggestions for the 1.0 release, fine to leave for a follow-up:
- The README could mention
cargo install deploy-rs, maybe with a crates.io badge. Right now it only covers Nix installation. - It might be worth starting a CHANGELOG, or at least drafting the notes for the GitHub release.
| deploy-rs = final.rustPlatform.buildRustPackage { | ||
| pname = "deploy-rs"; | ||
| version = "0.1.0"; | ||
| version = "1.0.0"; |
Member
There was a problem hiding this comment.
I'd suggest reading the version from Cargo.toml, so it doesn't drift on the next bump (same idea as the clap change):
Suggested change
| version = "1.0.0"; | |
| version = (builtins.fromTOML (builtins.readFile ./Cargo.toml)).package.version; |
Cargo.toml is already in src, so nothing else needs to change.
Member
Author
@Martoon-00, I agree with you. Did both. |
Martoon-00
approved these changes
Oct 19, 2026
Martoon-00
left a comment
Martoon-00
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for addressing my concerns )
Problem: `deploy-rs` is about to be published on crates.io, but its version is still the placeholder `0.1.0` in `Cargo.toml`, `Cargo.lock` and the Nix package. Solution: set it to `1.0.0` in `Cargo.toml` and `Cargo.lock`, and make the Nix package read its version from `Cargo.toml`, so the crate and the Nix package always report the same version.
Problem: `deploy` and `activate` hardcode `version = "1.0"` in their clap attributes. With the crate at 1.0.0, `--version` prints `1.0`, and it would stay `1.0` after any later version bump. Solution: use `#[command(version)]`, which makes clap read the version from `Cargo.toml`. Both binaries now print `deploy-rs 1.0.0`.
Problem: deploy-rs has no changelog, and the 1.0.0 release needs an entry that says what the release is. Solution: add `CHANGELOG.md` in the Keep a Changelog format, with a 1.0.0 entry and an empty Unreleased section.
Problem: deploy-rs is about to be published on crates.io, but the README only shows how to run it with Nix. Solution: add a crates.io badge, and explain that `cargo install deploy-rs` installs the `deploy` and `activate` binaries, needs Rust 1.85 or newer, and still needs Nix on the machine.
heitor-lassarote
force-pushed
the
heitor-lassarote/#407-release-1.0.0
branch
from
October 19, 2026 13:32
8dc2951 to
1db2607
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prepares the first crates.io release, version
1.0.0.1.0.0inCargo.tomlandCargo.lock. The Nix package inflake.nixreads it fromCargo.toml.deployandactivateread their--versionfromCargo.tomlinstead of the hardcoded1.0. Both now printdeploy-rs 1.0.0.CHANGELOG.mdwith the 1.0.0 entry.cargo install.The publish, the
v1.0.0tag and the GitHub release follow on the day this is merged.Related issue(s)
Fixed #407. Fixed #409. Related: #72.
🤖 Generated with Claude Code