Repository navigation
Make scCODA results writable to h5mu - #1198
Merged
Merged
Conversation
arviz 1.x returns az.summary as arviz_stats' SummaryDataFrame, a pandas subclass that survives .loc and .copy, so intercept_df and the effect_df_* frames stored in varm had no anndata writer. The numpy_nullable conversion additionally turned the float64 summary columns into Float64 extension arrays, which anndata cannot write either. summary_prepare now returns plain float64 DataFrames; the values are unchanged. Verified by writing and reading back a sampled haber_2017_regions MuData, which failed on main with arviz 1.3.0 and arviz-stats 1.3.3.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1198 +/- ##
=======================================
Coverage 74.12% 74.12%
=======================================
Files 57 57
Lines 8895 8895
=======================================
Hits 6593 6593
Misses 2302 2302
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1194.
summary_preparenow returns plain float64 DataFrames instead of arviz 1.x'sSummaryDataFramesubclass with nullable Float64 columns, so scCODA and tascCODA results stored invarmcan be written withwrite_h5muagain.