Skip to content

Add regression tests for ISO-8859-1 feeds - #202

Merged
DCjanus merged 4 commits into
rust-syndication:masterfrom
emschwartz:latin1-regression-tests
Nov 10, 2026
Merged

DCjanus merged 4 commits into
rust-syndication:masterfrom
emschwartz:latin1-regression-tests

Conversation

@emschwartz

Copy link
Copy Markdown
Contributor

Adds regression tests for feeds declaring ISO-8859-1 with a non-ASCII byte (\xE9) in the channel title: one with a short declaration, one with a declaration longer than 64 bytes (extra whitespace). Both assert the decoded value Café. Tests only, no code changes.

They pass on the current quick-xml 0.41. A bump to quick-xml 0.42 breaks them: 0.42 no longer decodes non-UTF-8 input in Reader, and the DecodingReader replacement fails the long-declaration case (Xml(Encoding(Other(UTF-8))); see tafia/quick-xml#1040). The bump should wait until that is resolved.

Authored by Claude (claude-sonnet-5-5).

Cover a short declaration and one longer than 64 bytes, each with a
non-ASCII byte in the channel title.

Co-Authored-By: Claude <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.48%. Comparing base (8598600) to head (8efea17).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   80.98%   82.48%   +1.50%     
==========================================
  Files          23       23              
  Lines        1530     1547      +17     
==========================================
+ Hits         1239     1276      +37     
+ Misses        291      271      -20     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Assisted-by: codex:gpt-6.1-sol
Assisted-by: codex:gpt-6.1-sol
Assisted-by: codex:gpt-6.1-sol
@DCjanus

DCjanus commented Nov 10, 2026

Copy link
Copy Markdown
Member

Wow, nice catch! Thanks for digging into this and adding the regression tests.

I added a link to the upstream quick-xml issue in the test comment so future readers can easily find the context.

@DCjanus
DCjanus merged commit 53bc3ca into rust-syndication:master Nov 10, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants