Repository navigation
Add regression tests for ISO-8859-1 feeds - #202
Merged
DCjanus merged 4 commits intoNov 10, 2026
Merged
Conversation
Cover a short declaration and one longer than 64 bytes, each with a non-ASCII byte in the channel title. Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #202 +/- ##
==========================================
+ Coverage 80.98% 82.48% +1.50%
==========================================
Files 23 23
Lines 1530 1547 +17
==========================================
+ Hits 1239 1276 +37
+ Misses 291 271 -20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Assisted-by: codex:gpt-6.1-sol
Assisted-by: codex:gpt-6.1-sol
Assisted-by: codex:gpt-6.1-sol
Member
|
Wow, nice catch! Thanks for digging into this and adding the regression tests. I added a link to the upstream quick-xml issue in the test comment so future readers can easily find the context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds regression tests for feeds declaring ISO-8859-1 with a non-ASCII byte (
\xE9) in the channel title: one with a short declaration, one with a declaration longer than 64 bytes (extra whitespace). Both assert the decoded valueCafé. Tests only, no code changes.They pass on the current quick-xml 0.41. A bump to quick-xml 0.42 breaks them: 0.42 no longer decodes non-UTF-8 input in
Reader, and theDecodingReaderreplacement fails the long-declaration case (Xml(Encoding(Other(UTF-8))); see tafia/quick-xml#1040). The bump should wait until that is resolved.Authored by Claude (claude-sonnet-5-5).