Conversation
This was referenced Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In giallo, the PHP grammar (https://github.com/shikijs/textmate-grammars-themes/blob/4cb1625ad87a07fb4674fe97b921a8f756f4694b/packages/tm-grammars/grammars/php.json) has a lot of patterns like
(?i)[_a-z\x7F-\x{10FFFF}].With master case folding, it would iterate every codepoint and be generally slow. Replacing it with an iterator that looks at the table directly is much faster. The code is also much simpler, I'm not sure if I'm missing something tbh.
Benchmark results with the added bench from that PR:
master:
this branch:
So about 70x faster for that pattern and no changes for simpler ones.
Kinda related: #893