Skip to content

Fix CI container name collision on podman runners #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anvacaru merged 3 commits into from
Sep 28, 2026
Merged

Fix CI container name collision on podman runners #2881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7a7693
force remove any existing containers with the target name
anvacaru Sep 10, 2026
e0f211d
restore comments on tear-down steps
anvacaru Sep 23, 2026
c6fb162
Merge remote-tracking branch 'origin/master' into anvacaru/ci-contain…
anvacaru Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/with-docker/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ runs:
--build-arg LLVM_VERSION="${LLVM_VERSION}" \
--build-arg UV_VERSION="${UV_VERSION}"

docker rm -f "${CONTAINER_NAME}" || true

docker run \
--name "${CONTAINER_NAME}" \
--rm \
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ jobs:
run: |
# Best effort: the container does not exist if 'Set up Docker' failed, and a
Comment thread
anvacaru marked this conversation as resolved.
# non-zero exit here would mask the step that actually failed.
docker stop --timeout=0 kevm-ci-concrete-${{ github.sha }} || true
docker rm -f kevm-ci-concrete-${{ github.sha }} || true

test-prove:
name: 'Proofs: ${{ matrix.name }}'
Expand Down Expand Up @@ -172,7 +172,7 @@ jobs:
run: |
# Best effort: the container does not exist if 'Set up Docker' failed, and a
# non-zero exit here would mask the step that actually failed.
docker stop --timeout=0 kevm-ci-haskell-${{ matrix.test-suite }}-${{ github.sha }} || true
docker rm -f kevm-ci-haskell-${{ matrix.test-suite }}-${{ github.sha }} || true

nix:
name: 'Nix'
Expand Down
Loading