Skip to content

Skip checksum computation when opener=None [RHELDST-45142] - #413

Merged
rbikar merged 1 commit into
release-engineering:masterfrom
crungehottman:konflux-src-md5sum
Oct 13, 2026
Merged

rbikar merged 1 commit into
release-engineering:masterfrom
crungehottman:konflux-src-md5sum

Conversation

@crungehottman

Copy link
Copy Markdown
Member

Items without a local file opener (opener=None) are now passed through the LoadChecksums phase without attempting to read src. This fixes a FileNotFoundError crash for KonfluxSource items where src is a Pulp href rather than a local file path, and is not intended to be read as a file. Missing staged files (opener=open_src_local) still fail as expected.

Requires pushsource release with opener=None on KonfluxSource RPM items (release-engineering/pushsource#721).

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d3550ecb-cc41-4b21-92f8-18b7dc849c86


Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.81%. Comparing base (326da25) to head (7501368).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          56       56           
  Lines        3228     3231    +3     
=======================================
+ Hits         3222     3225    +3     
  Misses          6        6           
Flag Coverage Δ
unit-tests 99.81% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rbikar
rbikar previously approved these changes Sep 30, 2026
Items without a local file opener (opener=None) are now passed
through the LoadChecksums phase without attempting to read src.
This fixes a FileNotFoundError crash for KonfluxSource items
where src is a Pulp href rather than a local file path, and is
not intended to be read as a file. Missing staged files
(opener=open_src_local) still fail as expected.

Requires pushsource release with opener=None on KonfluxSource
RPM items (release-engineering/pushsource#721).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@crungehottman

Copy link
Copy Markdown
Member Author

Updated commit with new version of pushsource which includes release-engineering/pushsource#721

@crungehottman

Copy link
Copy Markdown
Member Author

@rbikar when you get a chance, could you please approve and/or merge this? Thank you!

@rbikar
rbikar merged commit 36eda4c into release-engineering:master Oct 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants