Conversation
The kafka components consolidation (#3677) announced the kafka and kafka_franz inputs and outputs as deprecated in favour of redpanda, but only flipped the inputs. Mark the outputs Deprecated() to match, and sync info.csv.
Both examples used the kafka output, which fails `lint --deprecated` now that it's deprecated. joining_streams also sets metadata.include_patterns, since the redpanda output doesn't forward metadata as headers by default and the retry input reads last_attempted from them.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3677 announced the
kafkaandkafka_franzinputs and outputs as deprecated in favour ofredpanda, but only the inputs were flipped. This marks the outputsDeprecated()too and syncsinfo.csv.Deprecation only affects
lint --deprecatedand component listings; existing configs keep running.The two config examples that used the
kafkaoutput now useredpanda. Worth knowing for anyone making the same move, since the defaults differ:metadata.include_patternsis set (joining_streamsneeds it for its retry delay, so it's set there)acks=all, which needs the idempotent write ACL on the cluster🤖 Generated with Claude Code