Remove obsolete Android SDK compatibility shims - #58726
Open
Abbondanzo wants to merge 2 commits into
Open
Abbondanzo wants to merge 2 commits into
Abbondanzo wants to merge 2 commits into
Conversation
Summary: Use Android 15's `TextView.setUseBoundsForWidth` API directly instead of resolving and invoking it through reflection. The call remains guarded by the runtime SDK version. Preserve the shared numeric Android 15 version compatibility shim for builds that compile against older Android SDKs. Changelog: [Internal] Differential Revision: D122183946
Summary: Use `Build.VERSION_CODES` and the framework window attribute directly for APIs available in the current compile SDK, removing obsolete numeric compatibility shims. Retain only the Android 17 version shim, which is newer than the internal compile SDK. Remove a stale `DisplayMetrics` dependency that pulled edge-to-edge window code into unrelated consumers. Changelog: [Internal] Differential Revision: D122209144
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122209144. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Use
Build.VERSION_CODESand the framework window attribute directly for APIs available in the current compile SDK, removing obsolete numeric compatibility shims. Retain only the Android 17 version shim, which is newer than the internal compile SDK.Remove a stale
DisplayMetricsdependency that pulled edge-to-edge window code into unrelated consumers.Changelog:
[Internal]
Differential Revision: D122209144